Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline write_rfc2822_inner, don't localize #1322

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

pitdicker
Copy link
Collaborator

@pitdicker pitdicker commented Sep 26, 2023

As discussed in #1144 (comment) we should not localize the day and month names in write_rfc2822 with the unstable-locales feature, because the RFC requires English names.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #1322 (096eb5f) into 0.4.x (be8f2fd) will decrease coverage by 0.01%.
Report is 9 commits behind head on 0.4.x.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##            0.4.x    #1322      +/-   ##
==========================================
- Coverage   91.25%   91.24%   -0.01%     
==========================================
  Files          38       38              
  Lines       17114    17107       -7     
==========================================
- Hits        15617    15610       -7     
  Misses       1497     1497              
Files Coverage Δ
src/format/formatting.rs 92.46% <88.88%> (-0.08%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pitdicker pitdicker merged commit 22846c9 into chronotope:0.4.x Sep 27, 2023
36 of 37 checks passed
@pitdicker pitdicker deleted the english_rfc2822 branch September 27, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants