Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor internals module part 4 #1432

Merged
merged 4 commits into from
Feb 12, 2024

Conversation

pitdicker
Copy link
Collaborator

These commits add a way to construct an Mdf without going through an Of, and to get an ordinal and flags back out without going through Of. With that the last uses of Of are gone.

A final commit is to move cycle_to_yo and yo_to_cycle and the related array to the date module.

I found one comment in a backup branch that was better to have with the previous PR, sorry. Just stylistic comment changes to IsoWeek.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c4b119) 91.84% compared to head (ae14eb7) 91.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1432      +/-   ##
==========================================
+ Coverage   91.84%   91.87%   +0.02%     
==========================================
  Files          38       38              
  Lines       17571    17507      -64     
==========================================
- Hits        16138    16084      -54     
+ Misses       1433     1423      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pitdicker pitdicker merged commit 3016c30 into chronotope:main Feb 12, 2024
37 checks passed
@pitdicker pitdicker deleted the refactor_internals_4 branch February 12, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants