Merge 0.4.x #1435
Merged
Merge 0.4.x #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check is not necessary and prevented rounding and truncation from working correctly on timestamps close to the Unix epoch.
And add test against previous implementation
remove `Of::isoweekdate_raw`
pitdicker
force-pushed
the
merge_0.4.x
branch
from
1664f9a to
9c57b37
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 0.5.x #1435 +/- ##
==========================================
- Coverage 94.16% 94.15% -0.01%
==========================================
Files 34 37 +3
Lines 16824 16794 -30
==========================================
- Hits 15842 15813 -29
+ Misses 982 981 -1 ☔ View full report in Codecov by Sentry. |
pitdicker
force-pushed
the
merge_0.4.x
branch
from
9c57b37 to
882798e
Compare
djc
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get the refactor of the
internalsandnaive::datemodule on 0.5.x branch. (And of course everything that was part of the 0.4.34 release.)