Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format::strftime docs link #1581

Merged
merged 2 commits into from
May 23, 2024
Merged

Fix format::strftime docs link #1581

merged 2 commits into from
May 23, 2024

Conversation

frederikhors
Copy link
Contributor

Thanks for contributing to chrono!

If your feature is semver-compatible, please target the main branch;
for semver-incompatible changes, please target the 0.5.x branch.

Please consider adding a test to ensure your bug fix/feature will not break in the future.

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.78%. Comparing base (7e25ffb) to head (3e27bd7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1581   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files          37       37           
  Lines       18208    18208           
=======================================
  Hits        16713    16713           
  Misses       1495     1495           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pitdicker
Copy link
Collaborator

@frederikhors Thank you for the PR.

Could you link to the docs.rs page that has an invalid link? Because according to the CI your change turns a working link into a broken one.

@frederikhors
Copy link
Contributor Author

@pitdicker
Copy link
Collaborator

Strange. In some places I have been replacing such relative path links with the newer module syntax when I touch surrounding code:

[`format::strftime` module](crate::format::strftime)`

That should work here too and not break docs.rs.

@frederikhors
Copy link
Contributor Author

Do you mean like I just did now?

@djc
Copy link
Member

djc commented May 23, 2024

Broken CI is fixed in #1582. The change here looks good, but definitely want to see it pass the check_docs job in CI.

@djc
Copy link
Member

djc commented May 23, 2024

Can you rebase this on current main?

@pitdicker
Copy link
Collaborator

I think we can safely merge without rebasing. The doc change is good.

@djc djc merged commit f129a8b into chronotope:main May 23, 2024
34 of 35 checks passed
@pitdicker
Copy link
Collaborator

Thank you @frederikhors!

@frederikhors frederikhors deleted the patch-1 branch May 23, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants