-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix format::strftime docs link #1581
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1581 +/- ##
=======================================
Coverage 91.78% 91.78%
=======================================
Files 37 37
Lines 18208 18208
=======================================
Hits 16713 16713
Misses 1495 1495 ☔ View full report in Codecov by Sentry. |
@frederikhors Thank you for the PR. Could you link to the docs.rs page that has an invalid link? Because according to the CI your change turns a working link into a broken one. |
The link is to https://docs.rs/chrono/latest/chrono/datetime/format/strftime/index.html which is 404. |
Strange. In some places I have been replacing such relative path links with the newer module syntax when I touch surrounding code: [`format::strftime` module](crate::format::strftime)` That should work here too and not break docs.rs. |
Do you mean like I just did now? |
Broken CI is fixed in #1582. The change here looks good, but definitely want to see it pass the |
Can you rebase this on current main? |
I think we can safely merge without rebasing. The doc change is good. |
Thank you @frederikhors! |
Thanks for contributing to chrono!
If your feature is semver-compatible, please target the main branch;
for semver-incompatible changes, please target the
0.5.x
branch.Please consider adding a test to ensure your bug fix/feature will not break in the future.