The wasm-bindgen code refers to oldtime::Duration and is failing #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quodlibetor
force-pushed
the
fix-wasm-duration
branch
from
a091329
to
1df9222
Compare
|
Looks like this fixes my build issues 👍 |
quodlibetor
force-pushed
the
fix-wasm-duration
branch
from
8b9c071
to
a9dd784
Compare
|
@CryZe thanks for verifying, and sorry it broke your build! |
|
Looks like the comment regarding semver isn't actually implemented? |
|
If we're going to get pedantic about SemVer, breaking changes are permitted in minor or patch releases pre 1.0. It's Cargo that violates the SemVer spec on this point. |
lopopolo
added a commit
to artichoke/artichoke
that referenced
this pull request
Sep 27, 2020
See chronotope/chrono#478 which was released as chrono v0.4.16. This PR pegs the minimum chrono to 0.4.17 to pull in a wasm fix from chronotope/chrono#483.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasm only works on new-enough rust that we can unconditionally use the crate
keyword in that method, so let's try that.
#286 (comment)