Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update duration docs for oldtime feature #484

Merged
merged 1 commit into from
Sep 26, 2020

Conversation

benesch
Copy link
Contributor

@benesch benesch commented Sep 26, 2020

The main crate docs made some claims about the Duration type that became
incorrect with the new oldtime feature (#478).

Per @jhpratt.

Thanks for contributing to chrono!

  • Have you added yourself and the change to the changelog? (Don't worry
    about adding the PR number)
  • If this pull request fixes a bug, does it add a test that verifies that
    we can't reintroduce it?

The main crate docs made some claims about the Duration type that became
incorrect with the new oldtime feature (chronotope#478).

Per @jhpratt.
@quodlibetor quodlibetor merged commit 1402e8d into chronotope:main Sep 26, 2020
pickfire pushed a commit to pickfire/chrono that referenced this pull request Jan 22, 2022
The main crate docs made some claims about the Duration type that became
incorrect with the new oldtime feature (chronotope#478).

Per @jhpratt.
botahamec pushed a commit to botahamec/chrono that referenced this pull request May 26, 2022
The main crate docs made some claims about the Duration type that became
incorrect with the new oldtime feature (chronotope#478).

Per @jhpratt.
pickfire pushed a commit to pickfire/chrono that referenced this pull request Jul 5, 2022
The main crate docs made some claims about the Duration type that became
incorrect with the new oldtime feature (chronotope#478).

Per @jhpratt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants