Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DateTime::parse_from_str panicking #603

Closed
wants to merge 6 commits into from
Closed

Fix DateTime::parse_from_str panicking #603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5df65d1
Adding a fix and atest case. Todo: Fix the testcase
Vagelis-Prokopiou Oct 12, 2021
c8021bd
Updating gitignore
Vagelis-Prokopiou Oct 14, 2021
6c86490
Progress
Vagelis-Prokopiou Oct 14, 2021
a2e9809
Removing unused thingy
Vagelis-Prokopiou Oct 14, 2021
c8b2c76
Update src/format/scan.rs
Vagelis-Prokopiou Oct 26, 2021
720f9ad
Removing idea
Vagelis-Prokopiou Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/datetime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2830,6 +2830,10 @@ mod tests {
Utc.datetime_from_str("Fri, 09 Aug 2013 23:54:35 GMT", "%a, %d %b %Y %H:%M:%S GMT"),
Ok(Utc.ymd(2013, 8, 9).and_hms(23, 54, 35))
);

let input_from_fuzzing = "1%Z%I%A%Z%I%A\u{7f}\u{1c} 4ThuP0\u{7f}\n\u{2000}\n\n\u{2000}\n\nJ \u{0} %Z%s%Z%\u{0}%s%Zsssssssssssssssssss%sZ%I\nJ \n3%Z%";
let result = crate::DateTime::parse_from_str(input_from_fuzzing, input_from_fuzzing);
assert!(result.is_err());
}

#[test]
Expand Down
4 changes: 4 additions & 0 deletions src/format/scan.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,10 @@ pub fn short_or_long_month0(s: &str) -> ParseResult<(&str, u8)> {
/// Tries to parse the weekday with short or long weekday names.
/// It prefers long weekday names to short weekday names when both are possible.
pub fn short_or_long_weekday(s: &str) -> ParseResult<(&str, Weekday)> {
if !s.is_ascii() {
return Err(crate::format::ParseError(crate::format::ParseErrorKind::Invalid));
}

// lowercased weekday names, minus first three chars
static LONG_WEEKDAY_SUFFIXES: [&'static str; 7] =
["day", "sday", "nesday", "rsday", "day", "urday", "day"];
Expand Down