-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tz-info from local fixes #678
Conversation
Awesome work adding more tests, my changes definitely didn't have great test coverage! I'm having a hard time reviewing these changes, I'd like to cut this up into smaller commits that fix one issue at a time. Additionally I don't think we should bring in old chrono as a dependency, that seems like a brittle solution. On the other hand, shelling out to |
No problems - tests are almost passing and I need to do a few more cleanups, then will close this and split this out as much as possible.
My main goal with this was to verify if there was any breakage compared to the previous version. Potentially this could be broken out to a separate crate if it is worthwhile but not ideal in the main crate? However I guess the testing against |
@esheppa have you made any progress on this? Are there things I can help with? Would be nice to get this out soon. |
Hi @djc - still working through this, getting closer but still a few bugs left to fix. I'm ensuring this works for both regular transitions and alternative rules for all local timezones in |
@djc - I'm now ready to split this into multiple PRs as the tests are passing for all but a few tzdb timezones. There are two outstanding issues that may or may not need to be resolved, or may be able to be resolved later:
|
find_local_time_type_from_local
forTimeZoneRef
,TransitionRule
andAlternateTime
This is incomplete because at least the
AlternateTime::find_local_time_type_from_local
still requires more work.