Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer associated consts for MIN and MAX values #726

Merged
merged 2 commits into from
Jul 4, 2022
Merged

Prefer associated consts for MIN and MAX values #726

merged 2 commits into from
Jul 4, 2022

Conversation

djc
Copy link
Member

@djc djc commented Jul 4, 2022 •
edited
Loading

Replaces #713. Fixes #720.

@djc djc force-pushed the assoc-min-max branch from 08ef60a to 04b48fc Compare July 4, 2022 11:55
esheppa
esheppa reviewed Jul 4, 2022
View reviewed changes
src/naive/datetime/mod.rs Outdated Show resolved Hide resolved
@esheppa
Copy link
Collaborator

esheppa commented Jul 4, 2022

looks good!

@djc djc force-pushed the assoc-min-max branch from 04b48fc to bf829e9 Compare July 4, 2022 12:43
@djc djc force-pushed the assoc-min-max branch from bf829e9 to 5d37f41 Compare July 4, 2022 12:45
@djc djc merged commit 686f720 into main Jul 4, 2022
@djc djc deleted the assoc-min-max branch July 4, 2022 13:07
@djc djc mentioned this pull request Jul 4, 2022
Closed
@pitdicker pitdicker mentioned this pull request Jun 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esheppa esheppa esheppa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI is broken on cross-targets
2 participants
@djc @esheppa