Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't check serde support against our MSRV #994

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Don't check serde support against our MSRV #994

merged 1 commit into from
Mar 20, 2023

Conversation

djc
Copy link
Member

@djc djc commented Mar 20, 2023

serde now has a 1.56 MSRV via syn 2.

@djc
Don't check serde support against our MSRV
5dbb111 
serde now has a 1.56 MSRV via syn 2.
@djc djc requested a review from esheppa March 20, 2023 09:37
@djc djc changed the base branch from main to 0.4.x March 20, 2023 09:38
esheppa
esheppa approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@esheppa esheppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@esheppa esheppa mentioned this pull request Mar 20, 2023
Merged
@djc djc merged commit a6e7a3e into 0.4.x Mar 20, 2023
@djc djc deleted the msrv-no-serde branch March 20, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esheppa esheppa esheppa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djc @esheppa