For reduce worktime of lein cloverage
#69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 82.62% 81.62% -1.01%
==========================================
Files 55 55
Lines 3281 3281
Branches 361 366 +5
==========================================
- Hits 2711 2678 -33
- Misses 209 237 +28
- Partials 361 366 +5
Continue to review full report at Codecov.
|
alumi
reviewed
Apr 27, 2017
test/cljam/t_bam_indexer.clj
Outdated
| {:chr "chr1" :start 23000000 :end 24000000 :depth :deep} 10010 | ||
| {:chr "chr1" :start 23000000 :end 23500000 :depth :deep} 3806 | ||
| {:chr "*"} 0))))) |
There was a problem hiding this comment.
These are tests for #21. Please confirm that numbers of spans (regions in BAM file) differ.
There was a problem hiding this comment.
Thanks for your review.
I saw #21 and https://travis-ci.org/chrovis/cljam/jobs/193304007#L419 , I understood.
Restore original numbers of spans, and remove unrelated tests by d5d350f .
There was a problem hiding this comment.
How about this? I think it'll be faster!
(are [?param ?counts] (= (count (io/read-alignments r ?param)) ?counts)
{:chr "chr1" :start 23000000 :end 23001000 :depth :deep} 46 ;; 1 span
{:chr "chr1" :start 24900000 :end 24902000 :depth :deep} 3 ;; 2 spans
{:chr "chr1" :start 24000000 :end 24001000 :depth :deep} 6 ;; 3 spans
{:chr "chr1" :start 23260000 :end 23268650 :depth :deep} 58 ;; 4 spans
{:chr "chr1" :start 23430000 :end 23470000 :depth :deep} 55 ;; 5 spans
{:chr "*"} 0) ;; 1 span…ts / Remove unneeded `:depth :shallow` `:depth :pointer` tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bamreader-medium-filetest asdeftest-slow(It may causes decreasing of coverage a bit)about-bam-indexer-small-file test