Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cljam.algo.level. #93

Merged
merged 1 commit into from
Aug 3, 2017
Merged

Refactor cljam.algo.level. #93

merged 1 commit into from
Aug 3, 2017

Conversation

alumi
Copy link
Member

@alumi alumi commented Aug 2, 2017

Summary

Refactored cljam.algo.level

Changes

  • Reduced the number of stages, 3 => 2.
    • [before] serial splitting -> parallel processing -> serial merging
    • [after] parallel processing & splitting -> serial merging
  • Use volatile thread-local state to compute levels.

@alumi alumi requested a review from totakke August 2, 2017 09:45
@codecov
Copy link

codecov bot commented Aug 2, 2017

Codecov Report

Merging #93 into master will decrease coverage by 0.09%.
The diff coverage is 82.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #93     +/-   ##
=========================================
- Coverage   83.22%   83.13%   -0.1%     
=========================================
  Files          60       60             
  Lines        4162     4132     -30     
  Branches      452      451      -1     
=========================================
- Hits         3464     3435     -29     
  Misses        246      246             
+ Partials      452      451      -1
Impacted Files Coverage Δ
src/cljam/algo/level.clj 82.97% <82.85%> (-5.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1aa847...e032911. Read the comment docs.

Copy link
Member

@totakke totakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@totakke totakke merged commit 7066001 into master Aug 3, 2017
@totakke totakke deleted the feature/refactor-level branch August 3, 2017 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants