Fix a race condition in startNotification with the "valuechanged" event notifications #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request is a proposal to fix #72 by removing a race condition between startNotification and the "valuechanged" event notifications.
The unit test wraps the
StartNotify
call with an early event emission.An assertion is positioned to ensure that this early event is not lost.
With the original code, the new unit test fails with:
With the proposed code, all tests are passing.