Decouple EngineGpuKernels from Gui #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, yes this include must be a mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
#include "Gui/HelpStrings.h"inEngineGpuKernels\CellProcessor.cuhcoupledEngineGpuKernelswithGui.This lead that the CUDA compiler must receive parameters from C++ compiler, and if the parameters received is not avaliable for CUDA compiler, compiler error will be occured. The CUDA compiler error I mentioned at Discord is an example of that.
By removing
#include "Gui/HelpStrings.h"inEngineGpuKernels\CellProcessor.cuh, the problem I mentioned upon could be fixed. And the context of"Gui/HelpStrings.h"is not be used inEngineGpuKernels\CellProcessor.cuh, it is ok to be removed.