Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent parsing if frontmatter is not met #13

Open
chuangcaleb opened this issue Oct 6, 2023 · 1 comment
Open

Prevent parsing if frontmatter is not met #13

chuangcaleb opened this issue Oct 6, 2023 · 1 comment
Labels
📋 a/task Type: Task Effort ⚡️ o/perf Objective: Optimise performance
Milestone
MVP 2

Comments

@chuangcaleb
Copy link
Owner

No description provided.

@chuangcaleb chuangcaleb converted this from a draft issue Oct 6, 2023
@chuangcaleb chuangcaleb added ✨ o/feature (Feature Requests go to Discussions/Ideas!) Objective: New feature implementation 📋 a/task Type: Task Effort labels Oct 6, 2023
@chuangcaleb chuangcaleb moved this from Done to Todo in obsidian-fountain-live Oct 6, 2023
@chuangcaleb chuangcaleb added this to the MVP 2 milestone Oct 9, 2023
@chuangcaleb chuangcaleb moved this from Todo to In Progress in obsidian-fountain-live Oct 11, 2023
chuangcaleb added a commit that referenced this issue Oct 11, 2023
@chuangcaleb
feat: use state field to cond'ly decorate with Fountain (#13)
5f9f77b 
Thanks @liamcain
https://discord.com/channels/686053708261228577/1156305653460111460/1161382520814837882
@chuangcaleb
Copy link
Owner Author

Thanks to @liamcain for suggesting https://discord.com/channels/686053708261228577/1156305653460111460/1161382520814837882

This solution works! Though the changes aren't applied immediately as you change the frontmatter, you still have to update the editor first, for example, by typing something in. I'll tinker with a way to force an update on frontmatter change, and if possible to reduce computations of always checking the frontmatter every cycle.

@chuangcaleb chuangcaleb changed the title Create configuration to opt-in to Fountain formatting Create configuration to opt-in to Fountain parsing Oct 11, 2023
@chuangcaleb chuangcaleb added ⚡️ o/perf Objective: Optimise performance and removed ✨ o/feature (Feature Requests go to Discussions/Ideas!) Objective: New feature implementation labels Oct 11, 2023
@chuangcaleb chuangcaleb changed the title Create configuration to opt-in to Fountain parsing Prevent parsing if frontmatter is not met Oct 11, 2023
@chuangcaleb chuangcaleb moved this from In Progress to Done in obsidian-fountain-live Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📋 a/task Type: Task Effort ⚡️ o/perf Objective: Optimise performance
Projects
obsidian-fountain-live
Status: Done
Milestone
MVP 2
Development

No branches or pull requests
1 participant
@chuangcaleb