Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Reading View #41

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

NickEastNL
Copy link

As per the discussion here: #33

I believe I've added all important elements of the Fountain spec to render properly in read view. The only elements I've not done are (section) headings, since to me they already appear fine, and the boneyard.

The boneyard is especially complex because without empty lines the block renders as a single paragraph, with the asterisks interpreted as emphasis/italics. With empty lines, the start and end blocks are detected properly, but they all become separate paragraphs. Since I don't use the boneyard element, they are not intended to be rendered anyway, and otherwise the Obsidian "comment" syntax does the same thing, I've chosen not to add it. If you still want to, I can look at it. Alternatively it should be possible to convert syntax when exporting a Fountain document out of Obsidian.

Other than that, the changes should be self-explanatory, so let me know what you think.

@chuangcaleb chuangcaleb added good first issue Good for newcomers ✨ o/feature (Feature Requests go to Discussions/Ideas!) Objective: New feature implementation 📋 a/task Type: Task Effort labels Aug 8, 2024
@chuangcaleb chuangcaleb self-requested a review August 8, 2024 03:22
@chuangcaleb chuangcaleb changed the title Support for read view feat: support Reading View Aug 9, 2024
@chuangcaleb
Copy link
Owner

chuangcaleb commented Aug 9, 2024

Great work @NickEastNL! Thanks so much for contributing 😍
I've left some review comments.
I think I won't spend too much time and effort on refining Reading View, as it's not in my personal use case at all (and I'm not sure how many people do) but if it's small refactoring efforts, I can contribute there! I may offer some changes to your PR as well! We'll work on this together!

I've also matured so much in Typescript/CSS since I wrote this project. Refactoring efforts coming up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📋 a/task Type: Task Effort good first issue Good for newcomers ✨ o/feature (Feature Requests go to Discussions/Ideas!) Objective: New feature implementation
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants