Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing Chocolatey Moderation #274

Closed
BiggerNoise opened this issue Jul 16, 2017 · 7 comments
Closed

Failing Chocolatey Moderation #274

BiggerNoise opened this issue Jul 16, 2017 · 7 comments
Assignees
Labels
Milestone

Comments

@BiggerNoise
Copy link
Member

I'm trying to clear some of the old backlog. 0.8.7 has been released, but is failing moderation on the Chocolatey site. Specific issues are:

Please remove these files from your package:

content\ReadMe.RoundhousE.txt
docs\GettingStarted.docx
docs\LICENSE
docs\NOTICE

Because you have included binaries, you need to include tools\LICENSE.txt and tools\VERIFICATION.txt (see choco new for examples)

I have assigned @ferventcoder, but anyone can make the requested changes.

I'm going to pull in some of the outstanding pull requests to make an 0.8.8 and I'd like to release this to choclatey at the same time.

@ferventcoder
Copy link
Member

That's interesting but I get why those things would be pulled out.

BiggerNoise added a commit to BiggerNoise/roundhouse that referenced this issue Oct 13, 2017
Fixes most of chucknorris#274. Everything but the docs\LICENSE and docs\NOTICE needing to be removed.
@erikbra
Copy link
Member

erikbra commented Nov 13, 2017

Are we OK with calling this "done" for now, @BiggerNoise, @ferventcoder ? I think what is output from AppVeyor now in master should be approved in Chocolatey? I'm marking this as 0.9.0, supposing that you're OK with closing it. Please scream out if you disagree :)

@erikbra erikbra added this to the 0.9.0 milestone Nov 13, 2017
@BiggerNoise
Copy link
Member Author

It should close with the 0.9.0 release. I want to hold off closing it for real until we actually get through the moderation process.

@BiggerNoise
Copy link
Member Author

The 0.9.0 release has passed the automated chocolatey automation. I'll close this once I can install 0.9.0 from choco

@ferventcoder
Copy link
Member

Don't forget to edit that nuspec to not just have me as the software author. It's more folks, but you both definitely should be listed in there.

@ferventcoder
Copy link
Member

For next time.

@BiggerNoise
Copy link
Member Author

'nuff said

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants