Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One unit-test takes tens of seconds (testing md5 algorithm) #289

Closed
erikbra opened this issue Oct 26, 2017 · 2 comments
Closed

One unit-test takes tens of seconds (testing md5 algorithm) #289

erikbra opened this issue Oct 26, 2017 · 2 comments
Assignees
@BiggerNoise

Comments

@erikbra
Copy link
Member

erikbra commented Oct 26, 2017

roundhouse.tests.cryptography.CryptographicServiceSpecs+when_using_an_unofficial_md5_implementation.should_have_parity_with_official_implementation
roundhouse.tests.dll 1 min 20 sec 424 ms

I think that one can be modified - maybe not run as many iterations, maybe find some corner cases, and test them, or something. I don't think the unit test suite should be slowed down so much by one scenario :)
@BiggerNoise
Copy link
Member

Yeah, that's nuts. I'm about to merge #285. I'll see if I can't make this a bit more reasonable right after.

@BiggerNoise BiggerNoise self-assigned this Oct 26, 2017
@BiggerNoise BiggerNoise mentioned this issue Oct 27, 2017
Merged
@BiggerNoise
Copy link
Member

Fixed by #290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BiggerNoise BiggerNoise

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BiggerNoise @erikbra