Speed up test for MD5 implementation equivalence #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test was performing 1M iterations over a 10K byte field. This was taking 60-90s depending on the machine. I dropped this to 2K iterations.
|
Fixes #289 |
BiggerNoise
deleted the
bugfix/fix-really-really-ridiculously-long-md5-equivalence-test
branch
erikbra
reviewed
Oct 27, 2017
| @@ -55,7 +55,7 @@ public void should_be_able_to_pass_text_and_get_back_a_base_64_hash_of_the_text( | |||
| [TestFixture] | |||
| public class when_using_an_unofficial_md5_implementation | |||
| { | |||
| const int passes = 1000000; | |||
| const int passes = 2000; | |||
There was a problem hiding this comment.
I had to sweat for days micro-optimizing that code. Anything for my peeps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test was performing 1M iterations over a 10K byte field. This was taking
60-90s depending on the machine. I dropped this to 2K iterations.