Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated roundhouse.databases.oracle to managed Oracle ODP.NET driver #191

Closed
wants to merge 5 commits into from

Conversation

Buthrakaur
Copy link

There's no need to install Oracle Client on the machine nor to switch between 32/64bit versions of the driver with managed Oracle provider.

Lodewijk Sioen and others added 5 commits June 19, 2013 16:09
This is a workaround for a problem with NHibernate in combination with
the Microsoft Oracle driver. See
http://thebasilet.blogspot.be/2009/07/nhibernate-oracle-clobs.html for
details
Issue chucknorris#37 was not completely fixed. The customtype must be set
with a stringvalue for the driver to see the change
…fic SQL handling (slash as batch separator, PROMPT statement handling)
@ferventcoder
Copy link
Member

So is the requirement to move to .net 4.0 to take advantage of odp.net? If so, please split this up to multiple branches / pull requests and state that one depends on the other. Then we can evaluate the upgrade to .net 4.0 first separately. And then move to this.

Also, don't use master branch for PR's. You get weird things like your last commit that is there based on pulling instead of git fetch and rebase.

Hopefully this is helpful to get you started on where you need to go to move this forward.

@Buthrakaur
Copy link
Author

The main concern is using managed Oracle client, which doesn't require Oracle Client software installation. I'll clean up the PR a try it again - thanks for guidance.

I have a problem with the buildscript - ILMerge part in particular. I added Oracle.ManagedDataAccess.dll, but it doesn't get into the ILMerged folder so the merge process fails. Do you have any hint what should I modify in the buildscript to make it work, please?

@ferventcoder
Copy link
Member

Yes, in the build.custom folder look for ilmerge.pre.build.

@ferventcoder
Copy link
Member

Actually that is an incorrect statement. Just make sure that the file falls into the correct folder. It should do this as long as copy assembly is true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants