-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AnyCPU + NHibernate Oracle fix #73
Conversation
LodewijkSioen
commented
Aug 20, 2012
- We converted all the projects to AnyCPU because we needed to run roundhouse as part of a x64 msbuild script.
- We added a fix for issue (oracle) error when rh inserts a record into its own scriptsrun table #37 because the scripts failed in our Oracle environment
This is a workaround for a problem with NHibernate in combination with the Microsoft Oracle driver. See http://thebasilet.blogspot.be/2009/07/nhibernate-oracle-clobs.html for details
I believe someone else may have already provided the oracle fix as well...no matter. I'll get to these soon enough and evaluate each of them. Thanks! |
I'm eagerly awaiting the 2000 < script < 4000 fix :) |
Issue chucknorris#37 was not completely fixed. The customtype must be set with a stringvalue for the driver to see the change
Can you split these apart and issue two new pull requests? Typically this is done by performing the work in a branch and submitting that branch as a pull request. That way you can continue to submit new enhancements/fixes/etc without it putting an extra burden on us to work through a big pull request that has differences that may not be related. So real life example of why: I am ready to pull in the oracle fix, but I want to evaluate the AnyCPU a little longer. There was a reason it had issues awhile back and I need to evaluate it more closely to see if those bad image format exceptions still exist before accepting it. |
No problem, I'll see if I can get this done today. |
Much appreciated! |
Now in pull request #83 |
Thx |