Fix multiplatform compatibility #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though the builder image was pulling multi-arch images the final binary was being built for amd64 arch only.
Closed
|
In order for this to work, it needs to be built in an Arm machine, which Github currently does not offer. |
|
I have built the docker image locally in my Arm machine in order to make this work! |
chuhlomin
reviewed
Dec 6, 2023
|
We went ahead and forked the repo in order to build it in our Arm64 CI nodes! |
|
Merged and tagged as v1.9. |
|
It won’t work if it’s not compiled on Arm I think!
…On Sat, 9 Dec 2023 at 07:15, Konstantin Chukhlomin ***@***.***> wrote:
Merged and tagged as v1.9.
Could you please double check that it still works with
chuhlomin/render-template:v1.9?
If so, I'll update the v1 label.
—
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIFOF5Z3DUG3OUOJ4ULE4TYIPXYNAVCNFSM6AAAAABAGQDFB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBYGIZTSMJXGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Go supports cross compiling, I fixed it v1.9 version and tested it on ARM: $ uname -m
aarch64
$ docker run --platform linux/arm/v7 -t -i chuhlomin/render-template:v1.9
::error::failed to render template: template file not found (".kube.yml") |
sungik-choi
referenced
this pull request
in channel-io/bezier-react
Dec 18, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [chuhlomin/render-template](https://togithub.com/chuhlomin/render-template) | action | minor | `v1.8` -> `v1.9` | --- ### Release Notes <details> <summary>chuhlomin/render-template (chuhlomin/render-template)</summary> ### [`v1.9`](https://togithub.com/chuhlomin/render-template/releases/tag/v1.9) [Compare Source](https://togithub.com/chuhlomin/render-template/compare/v1.8...v1.9) #### What's Changed - Fix multiplatform compatibility by [@​pavlospt](https://togithub.com/pavlospt) in [https://github.com/chuhlomin/render-template/pull/17](https://togithub.com/chuhlomin/render-template/pull/17) #### New Contributors - [@​pavlospt](https://togithub.com/pavlospt) made their first contribution in [https://github.com/chuhlomin/render-template/pull/17](https://togithub.com/chuhlomin/render-template/pull/17) **Full Changelog**: chuhlomin/render-template@v1.8...v1.9 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on Monday after 10am before 7pm" in timezone Asia/Seoul, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/channel-io/bezier-react). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy45My4xIiwidXBkYXRlZEluVmVyIjoiMzcuOTMuMSIsInRhcmdldEJyYW5jaCI6ImFscGhhIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the builder image was pulling multi-arch images the final binary was being built for amd64 arch only.