forked from Azure/azure-sdk-for-net
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebase from main #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support for User MSI and CMK for Vaults * Fixing the tests
* Auto generate commit * Bump assembly version * Update AssemblyInfo.cs * Update Microsoft.Azure.Management.SecurityCenter.csproj * Update AzSdk.RP.props * Update Settings API tests * Update alerts api tests * Remove IOT depecated API tests Co-authored-by: Gal Grinblat <galgr@microsoft.com>
…ection string (#23446) * fix AccountName population for GetTableClient ctor * handle SAS generation with connectionString ctors
* parent 42d2f5d author m-redding <t-mredding@microsoft.com> 1623786616 -0600 committer m-redding <t-mredding@microsoft.com> 1629315887 -0400 Created Sample 9: ObservableEventDataBatch Sample for ObservableEventDataBatch Fixing Typo in Snippet Running Snippet Generator Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Updates to asserts Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Fixing asserts again Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Updating sample markdown file Cleaning up tests. Updating snippet definitions Updating formatting Updated tests and markdown to respond to comments. Moving the class Fixing some formatting, spelling, and details Finazlied markdown and tests. realigning with main realigning with main aligning ALIGNING Created Sample 9: ObservableEventDataBatch Sample for ObservableEventDataBatch Fixing Typo in Snippet Running Snippet Generator Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Updates to asserts Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Fixing asserts again Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Updating sample markdown file Cleaning up tests. Updating snippet definitions Updating formatting Updated tests and markdown to respond to comments. Moving the class Fixing some formatting, spelling, and details Finazlied markdown and tests. realigning with main Created Sample 9: ObservableEventDataBatch Sample for ObservableEventDataBatch Fixing Typo in Snippet Running Snippet Generator Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Updates to asserts Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Fixing asserts again Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Updating sample markdown file Cleaning up tests. Updating snippet definitions Updating formatting Updated tests and markdown to respond to comments. Moving the class Fixing some formatting, spelling, and details Finazlied markdown and tests. Created Sample 9: ObservableEventDataBatch Sample for ObservableEventDataBatch Fixing Typo in Snippet Running Snippet Generator Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Updates to asserts Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Fixing asserts again Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Updating sample markdown file Cleaning up tests. Updating snippet definitions Updating formatting Updated tests and markdown to respond to comments. Moving the class Fixing some formatting, spelling, and details Finazlied markdown and tests. realigning with main aligning ALIGNING * aligning * aligning * aligning * Adding skeleton files * updated to internal classes * test typo * responding to feedback * Fixing method name for OnSendSucceeded * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClientOptions.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClientOptions.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/SendEventBatchFailedEventArgs.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/SendEventBatchSucceededEventArgs.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/SendEventBatchSucceededEventArgs.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * responding to feedback * updating close to remove overload * adding int to task * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
* Update RecordedTestSanitizer.cs * Update RecordedTestSanitizer.cs * rerecord anomalytests * Update RecordedTestSanitizer.cs * update communication * update readme and formatting
The focus of these changes is to refine some clunky language in the doc comments and detail exceptions for non-obvious validations or when the scenario is well-known.
* parent 42d2f5d author m-redding <t-mredding@microsoft.com> 1623786616 -0600 committer m-redding <t-mredding@microsoft.com> 1629315887 -0400 Created Sample 9: ObservableEventDataBatch Sample for ObservableEventDataBatch Fixing Typo in Snippet Running Snippet Generator Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Updates to asserts Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Fixing asserts again Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Updating sample markdown file Cleaning up tests. Updating snippet definitions Updating formatting Updated tests and markdown to respond to comments. Moving the class Fixing some formatting, spelling, and details Finazlied markdown and tests. realigning with main realigning with main aligning ALIGNING Created Sample 9: ObservableEventDataBatch Sample for ObservableEventDataBatch Fixing Typo in Snippet Running Snippet Generator Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Updates to asserts Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Fixing asserts again Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Updating sample markdown file Cleaning up tests. Updating snippet definitions Updating formatting Updated tests and markdown to respond to comments. Moving the class Fixing some formatting, spelling, and details Finazlied markdown and tests. realigning with main Created Sample 9: ObservableEventDataBatch Sample for ObservableEventDataBatch Fixing Typo in Snippet Running Snippet Generator Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Updates to asserts Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Fixing asserts again Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Updating sample markdown file Cleaning up tests. Updating snippet definitions Updating formatting Updated tests and markdown to respond to comments. Moving the class Fixing some formatting, spelling, and details Finazlied markdown and tests. Created Sample 9: ObservableEventDataBatch Sample for ObservableEventDataBatch Fixing Typo in Snippet Running Snippet Generator Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Updates to asserts Update sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample09_ObservableEventBatchLiveTests.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Fixing asserts again Update sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample09_ObservableEventBatch.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Updating sample markdown file Cleaning up tests. Updating snippet definitions Updating formatting Updated tests and markdown to respond to comments. Moving the class Fixing some formatting, spelling, and details Finazlied markdown and tests. realigning with main aligning ALIGNING * aligning * aligning * aligning * Adding skeleton files * updated to internal classes * test typo * responding to feedback * Fixing method name for OnSendSucceeded * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClientOptions.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClientOptions.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/SendEventBatchFailedEventArgs.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubBufferedProducerClient.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/SendEventBatchSucceededEventArgs.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/SendEventBatchSucceededEventArgs.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * responding to feedback * updating close to remove overload * adding int to task * adding tests and proposal * Revert "adding tests and proposal" This reverts commit 3f4f15693dba6ad79f1d51fe02c9d8d28beb4a0c. * adding final things * aligning * aligning * Update sdk/eventhub/Azure.Messaging.EventHubs/design/proposal-event-hub-buffered-producer.md * fixing link Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
* Add claim check sample * Fix * Remove locale from link * Fix snippet * explicit types * TOC * PR FB * Add storage link * Fix build * Remove dynamic resource management. * Remove ARM storage dependency * Remove unnecessary artifacts * Add liveOnly * Fix * Delete LiveResourceManager.cs * Fix indentation * LiveOnly test * optional * Fix * Revert storage version change * connection string * Contributing guide
…3459) * update alias models * update api
* Update AutoRest C# version to 3.0.0-beta.20210820.3 * update param name Co-authored-by: m-nash <prognash@gmail.com>
* wip for generating common files * updates after merge * wip regen complete working on tests * updates after latest autorest changes using temp types.json file to work around autorest bug * update tests after regen changes * updates after merge * update lro plurality * typo fix * trim large lro recordings * remove temp files * update api * move files after merge
* fix: typo spelling grammar * fix: revert changes * fix: revert spesicif file's from reviewed changes
JsonData's `ToString()` method was changed to return unquoted strings when the underlying value is a string, instead of always returing the JSON representation of the value. Because of this, we must use `ToJsonString()` to get a JSON String that we can deserialize into a POCO.
* mark test as playback only update core version fix errorresponse reference * updated wrong package * update api
* mark test as playback only update core version fix errorresponse reference * updated wrong package * update api * bump arm version
… ProviderResourceType (#23472)
* LLC purview Account * use default credential * resolve comments * re-generate purveiw account to latest version * update collection test * update Readme * update purview Account API * record test case * update recorded test case * [Purview] Renames + Adopt "Clientlet" Design - Make some very general client names a little more specific by prefixing them with `Purview`. - Adopt "Clientlet" design, while we work on teaching the code generator how to do this. There are a few changes here: - The list methods for Resource Rule Sets and Collections are promoted to the root account client. - The `collectionName` parameter is promoted to be a client parameter instead of an operation parameter. - The public constructors for the clientlet types are supressed. - `Get<ClientletName>Client()` methods are added to the root client. * [Purview] Update Accounts README.md * [Purview] Mark methods virtual * [Purview] Run Export-API.ps1 Co-authored-by: Matt Ellis <matell@microsoft.com>
* Stress test deployment script resiliency fixes * Use PSModule-Helpers to install powershell-yaml Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* [Synapse] - Add deserializer for more models * update api * Refresh generated code Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>
* operation name mapping * update mapping as per CS
#23299) * Communication: Add new CallingServerClient constructor to support creation with TokenCredential * Update Tests with local Record and generated apis. (#23301) * Fix test cases for different CallingServerClient auth types. Update CallingServerClient snippets. Co-authored-by: Melissa Neubert <mneubert@microsoft.com> Co-authored-by: Zihan Zhang <43592314+zihzhan-msft@users.noreply.github.com>
* Log MSAL for ConfidentialClient
…23361) * Call AcquireTokenSilent after AuthenticationRecord has been fetched * handle MsalUiRequiredException
* add ai.location.ip and ai.user.userAgent mapping * update clientIP * revert generated class change * resolve PR comments
…3538) * update namespace for model types update armclient to add new mgmttelemetrypolicy * remove props change and update api * use set value
* update namespace for model types update armclient to add new mgmttelemetrypolicy * remove props change and update api * use set value * enable nullable
chunyu3
pushed a commit
that referenced
this pull request
May 17, 2023
…nd add test coverage (Azure#34743) * generated code using autorest * fix mongo collection functions in Custom/RestorableCosmosDBAccountResource.cs * Fix breaking changes that coming from the safeflatten * InAccount restore changes for all api kinds * resolve build errors and update mongo db inaccount restore tests * update session records * resolve build errors after merge conflicts * regenerated changes using dotnet build /t:GenerateCode * update default values * fix test with default identity * updated with eng\scripts\CodeChecks.ps1 -ServiceDirectory cosmosdb * update sesion records for failing pipeline * update sesion records for failing pipeline * update inaccount restore tests to use static time and session records for table and gremlin tests * Update recording * Update recording * update session records for sql and mongo and disable mongo inaccount restore tests * update generated files with latest * updated test case for burst capacity * update session records for database account operations * updated test case to not enable burst capacity in account creation (#2) * recorded all tests in DatabaseAccount (#3) * updated test case to not enable burst capacity in account creation * recorded all tests in DatabaseAccount * session recordings of DatabaseAccountTests * cross region restore updated test * test recordings update * updated recordings * added new group cross region restore * udpated recordings with playback verification * updated RestorabledatabaseAccountTests groupo * update session records for private end point tests * Rename BackupResource to CassandraClusterBackupResource * Update API * update changelog for new sdk release --------- Co-authored-by: Arthur Ma <arthurma@microsoft.com> Co-authored-by: Wei Hu <huwe@microsoft.com> Co-authored-by: Richa Sharma <richasharma@microsoft.com> Co-authored-by: Richa Sharma <richasharma.amu@gmail.com> Co-authored-by: dsapaliga <dsapaliga@microsoft.com>
chunyu3
pushed a commit
that referenced
this pull request
Jul 13, 2023
…leSnippets.cs. (Azure#37422) * Update Readme.md snippets to be populated by tool, added SampleSnippets.cs file as source. * Fixing missing double quote on region identifier. * Updating sample C# snippets and code (#2) * Updating sample C# snippets and code. * Use explicit type instead of var, remove blank lines from #if * Finished change to use explicit type instead of var --------- Co-authored-by: Rango Meadows <v-rameadows@microsoft.com> --------- Co-authored-by: Rango Meadows <v-rameadows@microsoft.com> Co-authored-by: Michal Materna <michal.materna@hotmail.com>
chunyu3
pushed a commit
that referenced
this pull request
Sep 19, 2023
…re#38386) * Update Readme.md snippets to be populated by tool, added SampleSnippets.cs file as source. * Fixing missing double quote on region identifier. * Updating sample C# snippets and code (#2) * Updating sample C# snippets and code. * Use explicit type instead of var, remove blank lines from #if * Finished change to use explicit type instead of var --------- Co-authored-by: Rango Meadows <v-rameadows@microsoft.com> * Replace async samples with synchronous code * Corrected reference to async samples in README.md --------- Co-authored-by: Rango Meadows <v-rameadows@microsoft.com> Co-authored-by: Michal Materna <michal.materna@hotmail.com>
chunyu3
pushed a commit
that referenced
this pull request
Feb 26, 2024
* Update autorest.md file with latest swagger and allow model duplication * Generate and upgrade sdk code * Customize redis common configuration code to include aad-enabled * Regenerate API file * Customize redis common configuration code to include aad-enabled * Mitigate breaking change * Create empty test-resources.json * Create FlushFunctionalTests.cs * Update assets.json * Add functional tests for aad (#2) Adds functional tests for aad * Update Channel Tests (#3) * Oscarba/fix (#4) * Update Channel Tests * Update correct data type * Push regenerated code * UpdateChannelFix (#5) * Update Channel Tests * Update correct data type * Update test * Update tag for assets after push for recordings * Address reviewer comments * Update generatred code after mergin in main * Update FTs for updated models * Update AAD FT * Update assets.json * Update changelog --------- Co-authored-by: Kanchan Joshi <kanchanjoshi@microsoft.com> Co-authored-by: Austin Tolani <austintolani@microsoft.com> Co-authored-by: Oscar Barbosa Aquino <32723476+Darfeikus@users.noreply.github.com>
chunyu3
pushed a commit
that referenced
this pull request
Apr 30, 2024
* Update Generator Version 3.0.0-beta.20240404.1 * Update SDK codes he_mi_3 * Update SDK codes de_he_2 * Update SDK codes ad_co_0 * Update SDK codes sq_wo_6 * Update SDK codes mi_pu_4 * Update SDK codes pu_sq_5 * Update SDK codes co_de_1 * Build fix * Build fix #2 * Build fix #3 --------- Co-authored-by: Alexander Sher <alsher@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new service
label and/or contact assigned reviewer.If the check fails at the
Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1
. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1
to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.