Bugfixes & Expanded Environment Support #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the python style colon line termination on the if statement. The colon was causing undesired behavior when executing this function in the fish shell. Reference the fish shell docs [example](https://fishshell.com/docs/current/cmds/if.html#example) of an `if` statement for proper syntax.
The GNU which v2.21 command found on CentOS Stream 8 behaves differently than the which command on Debian based systems such as Ubuntu 20.04. The GNU which command prints to stderr when the command is not found. This can cause an error message to be erroneously printed during our test for a locally installed VS Code binary. Redirecting stderr to /dev/null silences this error message so our code produces the same behavior for either version of the which command.
The binary location changed from `~/.vscode-server/bin/<commit-id>/bin/code` to `~/.vscode-server/bin/<commit-id>/bin/remote-cli/code` in [commit f4ba7dd12b684b144457c6fc6ccc9f4fe71bde3c](microsoft/vscode@f4ba7dd), which was released in [March 2022 (version 1.66)](https://github.com/microsoft/vscode/releases/tag/1.66.0).
The `capture_output` parameter was added to `subprocess.run()` in Python 3.7. Directing stdout & stderr to `subprocess.PIPE` accomplishes the same goal & is supported from Python 3.5.
Update documentation of supported/tested Python versions. Update documentation of `code` executable location.
|
I submitted this PR to your dev branch because it is marked as default, but I just noticed that the curl command in /conf.d/code-connect.fish points to the main branch. I imagine we will want to either merge this into the main branch or update the url in /conf.d/code-connect.fish. |
|
Hey @frecks , thanks for your pull request! Your update is much appreciated and will be merged. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @chvolkmann. Your code-connect utility has been incredibly useful! Thanks for taking the time to put this together. Here are a few updates that I hope you will find valuable. Please let me know if you need anything changed or have any questions.
A change in the March 2022 (version
1.66) release of VS Code broke an assumption code-connect was making about the location of the
codebinary. This pull request fixes that issue.This pull request also expands code-connect's supported environments to include CentOS Stream 8 machines running GNU
whichv2.21 and Python 3.5 or newer.Finally, I've fixed a small formatting bug with an
ifstatement in code.fish & I've updated the README/CHANGELOG/VERSION documents to note these changes.