Add escape_all_strings
option to Emitter
#129
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for this library. It's been great and has got me out of some sticky situations where
serde
is not flexible enough. Much appreciated.This PR makes a change to ensure typing between loading and emitting.
Problem
Consider the following YAML:
After one round of
YamlLoader -> YamlEmitter
the YAML is now:After a second round the YAML is then:
The YAML has now changed significantly and information has been lost.
Solution
I added an
emitter.escape_all_strings(bool)
function which forces allYAML::String
nodes to be wrapped in double-quotes.I would be interested on your opinion on two points:
"example": "0x00"
). I am not sure if this has side-effects too.Thank you for you time, happy to make changes as you require.