Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalar parser #135

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Scalar parser #135

wants to merge 6 commits into from

Conversation

gyscos
Copy link

@gyscos gyscos commented Aug 6, 2019

This is a rebased version of #37

@gyscos gyscos mentioned this pull request Aug 6, 2019
@gyscos
Copy link
Author

gyscos commented Aug 6, 2019

In the last commit I replaced the ... inclusive patterns with ..= since it's getting deprecated in 2 weeks. It got stabilized in rust 1.26 in may 2018, but appveyor and travis are using rust 1.17 and 1.24.

I also started using dyn Trait, again because of the imminent deprecation of dyn-less traits.

If supporting such old compilers is a priority, the last commit should be skippable. I suppose we may want instead to explicitly allow the deprecated syntax.

@gyscos
Copy link
Author

gyscos commented Aug 7, 2019

I updated the tag directive-handling code to not rely on NLL (it uses an intermediate "Action" enum to separate the read-borrowing peek from the write-borrowing update), and it now compiles on rust 1.27.0 (because of dyn syntax) and runs tests on 1.28.0 (because of a slice::from_ref in regex-syntax).

@jaesharp
Copy link

jaesharp commented Oct 1, 2019

I tested this with a naive rebase against upstream master ( 0ecbc23 ) this morning, it still passes all tests (there's a dead code warning). This functionality would be quite useful for me personally, but unfortunately I'm still rather new to rust so I'm unable to adequately review the code. I'd be willing to provide a bounty for successful merger with upstream and subsequent release of functionality in the next version of the upstream yaml-rust crate - 100 AUD in the currency of choice.

@softprops
Copy link

What would it take to push this forward?

@softprops
Copy link

If needed I would be willing to pick up where this left off

@davvid
Copy link

davvid commented Jan 29, 2024

FWIW I've merged this PR into my fork: https://github.com/davvid/yaml-rust

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants