-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scalar parser #135
base: master
Are you sure you want to change the base?
Scalar parser #135
Conversation
In the last commit I replaced the I also started using If supporting such old compilers is a priority, the last commit should be skippable. I suppose we may want instead to explicitly allow the deprecated syntax. |
I updated the tag directive-handling code to not rely on NLL (it uses an intermediate "Action" enum to separate the read-borrowing peek from the write-borrowing update), and it now compiles on rust 1.27.0 (because of |
I tested this with a naive rebase against upstream master ( 0ecbc23 ) this morning, it still passes all tests (there's a dead code warning). This functionality would be quite useful for me personally, but unfortunately I'm still rather new to rust so I'm unable to adequately review the code. I'd be willing to provide a bounty for successful merger with upstream and subsequent release of functionality in the next version of the upstream yaml-rust crate - 100 AUD in the currency of choice. |
What would it take to push this forward? |
If needed I would be willing to pick up where this left off |
FWIW I've merged this PR into my fork: https://github.com/davvid/yaml-rust |
This is a rebased version of #37