Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose info() api #190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expose info() api #190

wants to merge 1 commit into from

Conversation

olalonde
Copy link

Add a function that exposes the info value. This is needed since description() is deprecated.

@hoodie
Copy link
Contributor

hoodie commented Jul 14, 2022

If I understand this correctly this always gives you the same message as ScanError::to_string(). Is it really necessary to have it then?

@olalonde
Copy link
Author

Not exactly the same:

"mapping values are not allowed in this context at line 4 column 4" (to_string())
"mapping values are not allowed in this context" (info())

Personally, it would help me because I use yaml-rust to parse a section of a larger file so the column/line info is wrong from the perspective of the end user. Right now, I trim the message I receive from to_string but that's not very elegant.

@olalonde
Copy link
Author

@hoodie are you a maintainer of yaml-rust? I was under the impression it was unmaintained.

@hoodie
Copy link
Contributor

hoodie commented Jul 14, 2022

I am not, just reading along, because I contributed a little in the past. I don't think it's unmaintained, but the maintainer seldomly checks the PRs.

@olalonde
Copy link
Author

Ok well, the last commit was a year ago... That's pretty seldom indeed.

Ethiraric added a commit to Ethiraric/yaml-rust2 that referenced this pull request Aug 17, 2023
@davvid
Copy link

davvid commented Jan 29, 2024

FWIW I've merged this into my fork: https://github.com/davvid/yaml-rust

Ethiraric added a commit to saphyr-rs/saphyr that referenced this pull request Oct 2, 2024
Ethiraric added a commit to saphyr-rs/saphyr that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants