Convert torchtyping to jaxtyping for PyTorch>=2.4 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwyoo
force-pushed
the
chore/jaxtyping-migration
branch
from
a3e84aa to
ad53898
Compare
stsouko
pushed a commit
that referenced
this pull request
Oct 5, 2025
Merge in ASX-JFUG/chytorch from feature/split_model_instances to dev * commit 'fa2e1a664500072a8759726bb57a6c7a3f9f0fcb': minor improvements add unittest and make sagemaker-ready create copy of encoder for MC inference
|
Hi, thank you for the PR. |
|
@stsouko Sorry for the missing part (I just noticed it). I only used libraries installed independently in my local environment. Please keep in mind that I didn't update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, guys.
I'm using PyTorch>=2.4 and I'm getting errors related to torchtyping. The author of torchtyping suggested switching to jaxtyping, so I submitted a PR that applied it.
patrick-kidger/torchtyping#48 (comment)
Please let me know if there is any issue for this PR.