Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): added access=public, docs on actions #34

Merged
merged 1 commit into from
Oct 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,18 @@ name: Publish

# Inspired by:
# https://dev.to/xcanchal/automatic-versioning-in-a-lerna-monorepo-using-github-actions-4hij
# Problems:
# I tried to use github registry to publish public packages,
# but packages in github require auth to insall even if package is public.
#
# Lernau use npm for publish, even if npm client is set to yarn
# Publish only use npm as client and it ignore any config in yarnrc and npmClient settings
#
# Npm token will not be configured without registry-url set in setup-node
# To configure authToken for npm both registry-url and secret is needed.
#
# When publishing public package, publishConfig.access need to be stetup
#

on:
pull_request:
Expand Down Expand Up @@ -48,6 +60,7 @@ jobs:
echo "Version"
yarn dlx lerna version \
--conventional-commits \
--no-private \
--yes

echo "Publish"
Expand Down
3 changes: 3 additions & 0 deletions packages/eslint-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
"keywords": [
"eslint"
],
"publishConfig": {
"access": "public"
},
"dependencies": {
"@chyzwar/tsconfig": "^0.2.2",
"@typescript-eslint/eslint-plugin": "^6.7.3",
Expand Down
3 changes: 3 additions & 0 deletions packages/runner/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
"bin": "./lib/runner.js",
"description": "Simple task runner",
"sideEffects": false,
"publishConfig": {
"access": "public"
},
"scripts": {
"build": "tsc --build",
"build:watch": "tsc --build --watch",
Expand Down
4 changes: 3 additions & 1 deletion packages/tsconfig/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"version": "0.2.2",
"author": "chyzwar",
"license": "MIT",
"main": "./node.js",
"engines": {
"node": "18.x.x",
"yarn": "3.x.x"
Expand All @@ -12,6 +11,9 @@
"type": "git",
"url": "https://github.com/chyzwar/common"
},
"publishConfig": {
"access": "public"
},
"description": "Typescript configs",
"keywords": [
"typescript preset"
Expand Down