Delete files array to fix TS, require ember-basic-dropdown 6+ #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieTheWagner
changed the title
cibernox
approved these changes
Aug 2, 2022
Having these files specified was making it so types were not being shipped.
RobbieTheWagner
force-pushed
the
patch-1
branch
from
be7cb10 to
90aeec4
Compare
RobbieTheWagner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a breaking change because we now require ember-basic-dropdown 6+. This fixes many issues stemming from old EBD, but could be a breaking change, depending on how you were using it in your app.
Having this
filesarray specified was making it so types were not being shipped, so removing it should fix that hopefully.I also updated our CI setup to be closer to the ember-cli blueprints, for easier maintenance.
Closes #1521
Closes #1523
Closes #1524