Add @rootEventType argument and set mousedown as default
#1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also opened an MR in ember-basic-dropdown to add missing docs: cibernox/ember-basic-dropdown#903 |
mkszepp
approved these changes
Jul 31, 2024
| @@ -98,6 +98,7 @@ export interface PowerSelectArgs { | |||
| triggerClass?: string; | |||
| ariaInvalid?: string; | |||
| eventType?: string; | |||
| rootEventType?: string; | |||
There was a problem hiding this comment.
I think we should change to rootEventType?: 'click' | 'mousedown';, because only this two types are allowed.
But the better way is that we export this types in ebd, so this is always syned.
I have also discoverd that in ebd we have one time delared as string and one strict to click/mousedown. I will look to fix it in ebd and than, when we release the ebd we do update the type also here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@rootEventTypeto be passed on toBasicDropdown@rootEventTypetomousedownDescription
I noticed that we set
eventTypeto a default ofmousedownfor theember-basic-dropdowntrigger (see https://github.com/cibernox/ember-power-select/blob/3aec36878c8b2aa9cf335b7a2220ae448c359fa1/ember-power-select/src/components/power-select.hbs#L46C1-L46C47), but we don't set it forrootEventType, which is the event used when clicking outside of the dropdown to open/close. I believe these should be in sync and the default ofmousedownmakes sense (it's also how a default HTMLselectbehaves).We ran into this issue because the click event doesn't propagate when the original element is removed from the DOM. Causing selects to not close properly.