Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @searchFieldPosition argument #1864

Merged
merged 9 commits into from
Dec 11, 2024
Merged

Add @searchFieldPosition argument #1864

merged 9 commits into from
Dec 11, 2024

Conversation

mkszepp
Copy link
Collaborator

@mkszepp mkszepp commented Dec 8, 2024

Summary

Follow-up on #1752 & #1784, gradually introducing @searchFieldPosition (before-options | trigger).

Example

Single-selectionMulti-selection
@searchFieldPosition="before-options" (default)
power-select-searchFieldPosition-before-options

@searchFieldPosition="trigger"(NEW)
power-select-searchFieldPosition-trigger
@searchFieldPosition="trigger" (default)
power-select-searchFieldPosition-trigger

@searchFieldPosition="before-options"(NEW)
power-select-searchFieldPosition-before-options

Description

<PowerSelect /> instances will have @searchFieldPosition set to before-options by default with the option to change it to trigger.
<PowerSelectMultiple /> instances will have @searchFieldPosition set to trigger by default with the option to change it to before-options.

Demo of the new option you will find in docs under https://ember-power-select.com/docs/the-search section "Search field position"

Note: There was duplicated the input field for single, to make non braking changes... This we can maybe resolve in next major

@mkszepp mkszepp merged commit 5a97bea into master Dec 11, 2024
20 checks passed
@mkszepp mkszepp deleted the add-search-field-position branch December 11, 2024 06:45
@mkszepp
Copy link
Collaborator Author

mkszepp commented Dec 11, 2024

@alex-ju released in v8.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant