Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Na edição do perfil, o item "imagem" virar "foto de perfil" #584

Merged
merged 5 commits into from
Nov 5, 2018

Conversation

gag2502
Copy link
Contributor

@gag2502 gag2502 commented Oct 24, 2018

Descrição

Eu tive que alterar um campo da model de image para profile_photo, isso afetou as migrações e os testes.

Issues Relacionadas

resolves: #482

Checklist

  • Os commits seguem o padrão do projeto (Flake8 e afins)
  • Os testes estão passando e cobrem as mudanças
  • Marcou no título do pull request se ele é work in progress [WIP] ou se está pronto para revisão [REVIEW]

Imagens/Comentários

Estava assim :
captura de tela de 2018-10-24 10-04-24
Com a atualização ficou assim:
captura de tela de 2018-10-24 09-56-28

@gag2502 gag2502 self-assigned this Oct 24, 2018
@gag2502 gag2502 requested a review from a team October 24, 2018 12:42
@gag2502 gag2502 changed the title [WIP] Na edição do perfil, o item "imagem" virar "foto de perfil [WIP] Na edição do perfil, o item "imagem" virar "foto de perfil" Oct 24, 2018
@codecov
Copy link

codecov bot commented Oct 24, 2018

Codecov Report

Merging #584 into develop will not change coverage.
The diff coverage is 75%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #584   +/-   ##
========================================
  Coverage    73.47%   73.47%           
========================================
  Files          121      121           
  Lines         3220     3220           
  Branches       347      347           
========================================
  Hits          2366     2366           
  Misses         752      752           
  Partials       102      102
Impacted Files Coverage Δ
src/ej_profiles/forms.py 100% <100%> (ø) ⬆️
src/ej_profiles/models.py 70% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8179f03...9185557. Read the comment docs.

@gag2502 gag2502 changed the title [WIP] Na edição do perfil, o item "imagem" virar "foto de perfil" [REVIEW] Na edição do perfil, o item "imagem" virar "foto de perfil" Oct 24, 2018
Copy link
Collaborator

@fabiolamfleury fabiolamfleury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existem conflitos nos arquivos de traduções

@gag2502
Copy link
Contributor Author

gag2502 commented Oct 29, 2018

@fabiolamfleury resolvi os conflitos

@gag2502 gag2502 force-pushed the i482_change_profile_image_name branch from ec62d9f to 8b980bf Compare October 29, 2018 16:58
@gag2502 gag2502 force-pushed the i482_change_profile_image_name branch from 8b980bf to f2578a5 Compare October 29, 2018 16:59
@fabiolamfleury fabiolamfleury merged commit c2e26f4 into develop Nov 5, 2018
@delete-merged-branch delete-merged-branch bot deleted the i482_change_profile_image_name branch November 5, 2018 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Na edição do perfil, o item "imagem" virar "foto de perfil
2 participants