Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Mensagem de erro errada ao tentar comentar com um usuário não logado #634

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

rodrigocam
Copy link
Contributor

Descrição

  • Alterada lógica no jinja2 de comment-form para exibir o texto correto
  • Alterado contexto enviado pela rota conversation-detail
  • Alteração de quantidade restantes de comentários quando o usuário está deslogado

Issues Relacionadas

resolves: #630

Checklist

  • Os commits seguem o padrão do projeto (Flake8 e afins)
  • Os testes estão passando e cobrem as mudanças
  • Marcou no título do pull request se ele é work in progress [WIP] ou se está pronto para revisão [REVIEW]

Imagens/Comentários

@codecov
Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #634 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #634      +/-   ##
===========================================
+ Coverage    81.76%   81.78%   +0.01%     
===========================================
  Files          123      123              
  Lines         3269     3272       +3     
  Branches       357      357              
===========================================
+ Hits          2673     2676       +3     
  Misses         491      491              
  Partials       105      105
Impacted Files Coverage Δ
src/ej_conversations/routes/conversations.py 100% <ø> (ø) ⬆️
src/ej_conversations/roles.py 68.75% <100%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e5e72...5faa2eb. Read the comment docs.

@fabiolamfleury fabiolamfleury merged commit d0dc1a9 into develop Nov 13, 2018
@delete-merged-branch delete-merged-branch bot deleted the i630_wrong_comment_exhibition branch November 13, 2018 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Página da conversa para usuários deslogados exibe incorretamente o texto "vc atingiu limite de comentários"
2 participants