Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Bug de exibição de tags de uma conversa #664

Merged
merged 4 commits into from
Nov 30, 2018
Merged

Conversation

fabiolamfleury
Copy link
Collaborator

@fabiolamfleury fabiolamfleury commented Nov 28, 2018

Descrição

Correção da exibição de tags nas páginas de moderação, detalhe e card de conversa

Issues Relacionadas

resolves: #660

Checklist

  • Os commits seguem o padrão do projeto (Flake8 e afins)
  • Os testes estão passando e cobrem as mudanças
  • Marcou no título do pull request se ele é work in progress [WIP] ou se está pronto para revisão [REVIEW]

@fabiolamfleury fabiolamfleury changed the title I660 tags bug [WIP] Bug de exibição de tags de uma conversa Nov 28, 2018
@codecov
Copy link

codecov bot commented Nov 28, 2018

Codecov Report

Merging #664 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #664      +/-   ##
===========================================
+ Coverage    80.78%   80.79%   +0.01%     
===========================================
  Files          139      139              
  Lines         3762     3764       +2     
  Branches       415      414       -1     
===========================================
+ Hits          3039     3041       +2     
  Misses         600      600              
  Partials       123      123
Impacted Files Coverage Δ
src/ej_conversations/roles.py 80% <100%> (+0.37%) ⬆️
src/ej_conversations/forms.py 100% <100%> (ø) ⬆️
src/ej_conversations/routes/admin.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e2f0d8...01a092a. Read the comment docs.

@fabiolamfleury fabiolamfleury requested a review from a team November 28, 2018 14:05
@fabiolamfleury fabiolamfleury changed the title [WIP] Bug de exibição de tags de uma conversa [REVIEW] Bug de exibição de tags de uma conversa Nov 28, 2018
Copy link
Contributor

@rodrigocam rodrigocam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabiolamfleury existem conflitos, apenas isso para aceitar este PR!

@rodrigocam rodrigocam changed the title [REVIEW] Bug de exibição de tags de uma conversa [WIP] Bug de exibição de tags de uma conversa Nov 29, 2018
@fabiolamfleury
Copy link
Collaborator Author

@rodrigocam fixed!

@fabiolamfleury fabiolamfleury changed the title [WIP] Bug de exibição de tags de uma conversa [REVIEW] Bug de exibição de tags de uma conversa Nov 30, 2018
@rodrigocam rodrigocam merged commit cd11062 into develop Nov 30, 2018
@delete-merged-branch delete-merged-branch bot deleted the i660_tags_bug branch November 30, 2018 15:11
pablodiegoss added a commit that referenced this pull request Dec 3, 2018
[REVIEW] Bug de exibição de tags de uma conversa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tags ultrapassando limite do card
3 participants