Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly parse tweets with multiple images #53

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Correctly parse tweets with multiple images #53

wants to merge 2 commits into from

Conversation

TheoLeCalvar
Copy link

#48
Quick fix to handle tweets with multiple images.

@ciderpunx
Copy link
Owner

Thanks for this. Nice one. I'm going to need to test if it has any big performance cost before rolling it out.

@TheoLeCalvar
Copy link
Author

Ok.
I also have another patch for gifs if you are interested.
It is not complete though, only gifs video are supported, others need request to the API to get the url.

@rootless4real
Copy link
Contributor

Can this code handle emojis properly too?

@TheoLeCalvar
Copy link
Author

With this new commit it should strip the image and only keep the emoji in the alt attribute.
It looked OK but I don't have time to properly test it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheoLeCalvar @ciderpunx @rootless4real