Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing synth_data_utils #366

Conversation

sabinala
Copy link
Contributor

I fixed the bugs in this utils file. Probably won't need this again anyway :)

@sabinala sabinala linked an issue Aug 31, 2023 that may be closed by this pull request
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sabinala sabinala requested a review from JosephCottam August 31, 2023 19:07
@sabinala sabinala added the awaiting review PR submitter awaiting code review from reviewer label Aug 31, 2023
@sabinala
Copy link
Contributor Author

The corresponding issue and branch should be closed if the pull request is accepted

@SamWitty
Copy link
Contributor

The corresponding issue and branch should be closed if the pull request is accepted

@sabinala , you can use GitHub's closing keywords to automate this when you create a PR. See https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@djinnome
Copy link
Contributor

djinnome commented Jan 4, 2024

@sabinala Do you want to resolve these stale conflicts?

@sabinala
Copy link
Contributor Author

sabinala commented Jan 8, 2024

@djinnome I think this is a depricated issue, the synth_data_utils file does not exist in the main branch anymore. I recommend deleting this issue. Let me know if you think differently.

@djinnome
Copy link
Contributor

djinnome commented Jan 8, 2024

Is there anything from synth_data_utils that you want to keep?

@sabinala
Copy link
Contributor Author

sabinala commented Jan 8, 2024

No, that's not necessary.

@sabinala
Copy link
Contributor Author

sabinala commented Jan 8, 2024

We're going to create synthetic data in another way, in response to this issue #448

@SamWitty
Copy link
Contributor

Closing this PR and issue at @sabinala 's description above. Please reopen if you believe this was closed by mistake.

@SamWitty SamWitty closed this Feb 13, 2024
@sabinala sabinala deleted the 328-synth_data_utils-has-functions-that-cannot-be-executed branch February 21, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review PR submitter awaiting code review from reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

synth_data_utils has functions that cannot be executed
3 participants