Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added typing fixes after pyro==1.9.0 bump #485

Closed
wants to merge 2 commits into from
Closed

Conversation

SamWitty
Copy link
Contributor

@SamWitty SamWitty commented Feb 20, 2024

This small PR addresses a number of linting errors that were introduced as a result of more refined types from the pyro 1.9.0 release https://github.com/pyro-ppl/pyro/releases/tag/1.9.0.

Currently blocked by some upstream changes that need to be made in ChiRho.

@SamWitty SamWitty self-assigned this Feb 20, 2024
@SamWitty SamWitty added WIP PR submitter still making changes, not ready for review blocked labels Feb 20, 2024
@SamWitty SamWitty marked this pull request as draft February 21, 2024 20:48
@djinnome
Copy link
Contributor

djinnome commented Jan 8, 2025

@SamWitty is there any timeline on when to expect ChiRho to update its dependencies beyond pyro-ppl==1.8.6?

https://github.com/BasisResearch/chirho/blob/6b9482b01b66e17e1880a0bb40c7e099bcd63aae/setup.py#L44C1-L45C1

@SamWitty SamWitty added the wontfix This will not be worked on label Jan 8, 2025
@djinnome
Copy link
Contributor

djinnome commented Jan 8, 2025

@SamWitty said this is unlikely to change before the ASKEM program ends.

@djinnome djinnome closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked WIP PR submitter still making changes, not ready for review wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants