Refactor Video Game #586
Merged
Refactor Video Game #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
|
Converting to draft until fixing it. |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This reverts commit bac4da6.
|
@cieslarmichal Now it's good for review. |
cieslarmichal
approved these changes
May 25, 2024
00thirdeye00
pushed a commit
to 00thirdeye00/faker-cxx
that referenced
this pull request
Jun 20, 2024
* Add VideoGameData draft Signed-off-by: Uilian Ries <uilianries@gmail.com> * Add rest of data to VideoGame Signed-off-by: Uilian Ries <uilianries@gmail.com> * Fix helper usage for video game Signed-off-by: Uilian Ries <uilianries@gmail.com> * avoid circular include Signed-off-by: Uilian Ries <uilianries@gmail.com> * build missing videogame data Signed-off-by: Uilian Ries <uilianries@gmail.com> * Add namespace for videogame Signed-off-by: Uilian Ries <uilianries@gmail.com> * Use video game namespace for testing Signed-off-by: Uilian Ries <uilianries@gmail.com> * fix genres conflict Signed-off-by: Uilian Ries <uilianries@gmail.com> * Use explicit namespace Signed-off-by: Uilian Ries <uilianries@gmail.com> * use separated name for video game genres Signed-off-by: Uilian Ries <uilianries@gmail.com> * Revert "fix genres conflict" This reverts commit bac4da6. --------- Signed-off-by: Uilian Ries <uilianries@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #580