-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kRSUnicode bug #315
Comments
This is fixed by the latest unihan_etl release (we're around 0.33.1 now) |
@tony Just a heads-up that you'll likely need to handle 3 apostrophes here when Unicode 16.0 comes out. Details on why here: https://www.unicode.org/review/pri483/feedback.html#ID20240328172102 |
@garfieldnate Thank you for catching that! Adding #318 for supporting this. I will keep an eye on https://www.unicode.org/reports/tr38/proposed.html as well (I suppose that's when we know for sure it'll be 3 apostrophes?) |
I believe so, yes. I didn't actually catch this change myself; Ken Lunde wrote me to let me know, which was very kind :D |
@tony Ken Lunde tells me that the change has been accepted by the group, and he has updated the docs here: https://www.unicode.org/reports/tr38/proposed.html#N101E4. The 16.0 beta will be out with this change on 5/21. |
@garfieldnate Thank you Aside:
|
No problem! The note from Ken Lunde:
|
Resolves #318. # Changes ## Revision 37 updates These changes align with Unicode Technical Report #38's [37th revision](https://www.unicode.org/reports/tr38/tr38-37.html#Modifications) and are part of ongoing improvements to Unihan data handling. ### Add `kFanqie` and `kZhuang` Adds support for the `kFanqie` and `kZhuang` fields. See also: - https://www.unicode.org/reports/tr38/#kFanqie - https://www.unicode.org/reports/tr38/#kZhuang ### Support `kRSUnicode` for apostrophes `Unihan_IRGSources`: Updated `kRSUnicode` for apostrophes. See also: - https://www.unicode.org/reports/tr38/#ChronologicalListing - #318 - #315 (comment) ### Removals - `kFrequency`: Removed from `Unihan_DictionaryLikeData`, `constants`, and `datapackage.json`. See also: - https://www.unicode.org/L2/L2024/24006.htm#178-C17 - https://www.unicode.org/reports/tr38/#ChronologicalListing ### Tests - Added tests for simplified expansions to ensure correctness of `kFanqie` and `kZhuang`.
See also: #233 (comment)
The text was updated successfully, but these errors were encountered: