Skip to content

Commit

Permalink
multicluster: correctly specify the dst context to clustermes connect
Browse files Browse the repository at this point in the history
Use the correct variable to specify the destination context for the
clustermesh connect step, which is otherwise left empty:

  cilium --context gke... clustermesh connect --destination-context ''

Although the workflow is currently working regardless (as the context
referring to the second cluster is the default one), that no longer
applies when pulling in the latest Cilium CLI changes, as --dst-context
has been converted to possibly take a list of contexts.

Fixes: f2fba32 ("multicluster: Run cilium-cli inside a container")
Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
  • Loading branch information
giorio94 committed Sep 23, 2024
1 parent b4a467c commit 9b980bf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/multicluster.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ jobs:
$(kubectl --context "${{ steps.contexts.outputs.cluster2 }}" get svc -n kube-system clustermesh-apiserver -o jsonpath='{.metadata.annotations}')
# Connect clusters
cilium --context "${{ steps.contexts.outputs.cluster1 }}" clustermesh connect --destination-context "${CONTEXT2}"
cilium --context "${{ steps.contexts.outputs.cluster1 }}" clustermesh connect --destination-context "${{ steps.contexts.outputs.cluster2 }}"
# Wait for cluster mesh status to be ready
cilium --context "${{ steps.contexts.outputs.cluster1 }}" clustermesh status --wait
Expand Down

0 comments on commit 9b980bf

Please sign in to comment.