Prepare for #2755 - Dockerfile only #2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the Dockerfile for now as discussed with @michi-covalent because it will diverge everytime taken from the original commit: -- This way we are not diverging in multiple dockerfiles and we can choose between two targets: - cilium-cli-ci The original target based on ubuntu and the default - cilium-cli Only contains the cilium cli based on scratch -- Signed-off-by: Merijn Keppel <merijnkeppel@gmail.com>
Keep behaviour of original cilium-cli-ci image to have empty entrypoint Add behaviour for cilium-cli (scratch) image to run cilium by default Signed-off-by: Merijn Keppel <merijnkeppel@gmail.com>
|
regarding publishing cilium-cli release images, let's get some input from @cilium/security team to find out whether we need to sign images, generate SBOM, etc.. if you can join weekly community meeting it might be quicker to get feedback from them: https://docs.cilium.io/en/latest/community/community/#weekly-community-meeting otherwise please open a slack thread in #development channel 🚀🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the Dockerfile for now as discussed with @michi-covalent because it will diverge everytime
taken from the original commit:
--
This way we are not diverging in multiple dockerfiles and we can choose between two targets: