-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows to disable helm validation #18297
Allows to disable helm validation #18297
Conversation
Fixes cilium#16552 Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
7b9bdca
to
5f4e9a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The change looks good overall. It should be noted that it disables the whole Helm validation, when there was just one check that seemed to cause an issue in the original bug report, but I think it's OK.
One thing I would like is to keep a bit more context for the change. Could you please explain why this change is required, and why helm template
doesn't work in your commit description? It's not fun to go and search for the PRs when git blaming
a change to find the initial motivation. I'm also wondering whether we should extend the description of the new option to tell users why it might be desirable to disable the checks.
@@ -1798,3 +1798,6 @@ cgroup: | |||
# -- Configure whether to enable auto detect of terminating state for endpoints | |||
# in order to support graceful termination. | |||
enableK8sTerminatingEndpoint: true | |||
|
|||
# -- Allows to disable the helm validation checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# -- Allows to disable the helm validation checks | |
# -- Allows to disable the Helm validation checks |
@@ -1798,3 +1798,6 @@ cgroup: | |||
# -- Configure whether to enable auto detect of terminating state for endpoints | |||
# in order to support graceful termination. | |||
enableK8sTerminatingEndpoint: true | |||
|
|||
# -- Allows to disable the helm validation checks | |||
enableHelmValidation: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please preserve the line break at the end of the line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please also run make -C install/kubernetes
to update the Helm Chart README.
While I'm not opposed to be able to opt-out from the validation, I would like to point out that the referenced issue is better solved by specifying the supported api-versions manually rather than disabling validation: #16552 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
My opinion is that it seems like a clunky approach to workaround a problem when installing Helm charts. Ideally, we shouldn't need to provide an opt-out if the solution to the root issue is what @gandro suggested. @farodin91 Has that worked for you or are there more use cases for opting out of Helm validation?
@gandro I'm currently playing around with ArgoCD. It seems the issue is solved with Argo CD 2.2. I'm okay with closing this PR. It could be helpful to document how to run helm template correctly. |
I see. Looking at argoproj/argo-cd#7291 indeed seems that Argo CD has remaining bugs around |
Validation issue of the servicemonitor is solved in argo 2.2. I would add a workaround only, if there another issue. I've you want that cilium wants this workaround, i'll update the PR to fix all comments. |
I'm not aware of any other issues related to validation at the moment. So yes, let's close this then. We can always re-open if we discover another issue. @farodin91 Thanks a ton for looking into this and doing the work. Even if this will not be merged, your contribution and input was most welcome! |
Fixes #16552
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes: #issue-number