btf: correct printing size of Int type in bytes #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems OK that the printing size of Int type in bits.
But while printing a struct, like 'struct sk_buff', it seems strange
that the printing size units of Int type and Struct/Union type are
different:
: offset=1088
: Union[fields=2]
size: 4
csum: offset=0
csum: Typedef:"__wsum"[Typedef:"__u32"]
__wsum: Typedef:"__u32"[Int:"unsigned int"]
__u32: Int:"unsigned int"[unsigned size=32]
: offset=0
: Struct[fields=2]
priority: offset=1120
priority: Typedef:"__u32"[Int:"unsigned int"]
__u32: Int:"unsigned int"[unsigned size=32]
So, it's better to make the printing size of Int type in bytes same as
Struct/Union type.
Signed-off-by: Leon Hwang <hffilwlqm@gmail.com>
Asphaltt
force-pushed
the
btf/int_type_size
branch
from
0c349b4
to
bc41df4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems OK that the printing size of Int type in bits.
But while printing a struct, like 'struct sk_buff', it seems strange that the printing size units of Int type and Struct/Union type are different:
So, it's better to make the printing size of Int type in bytes same as Struct/Union type.