Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Make audit verdicts visible in hubble-ui #460

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

niklasbeinghaus
Copy link
Contributor

@niklasbeinghaus niklasbeinghaus commented Mar 7, 2023

This is a WIP regarding #459

@geakstr
Copy link
Collaborator

geakstr commented Jun 6, 2023

Verified that is works locally
image

By the end I made this that "audit" flows only visible when you have Audit verdict filter selected explicitly, otherwise only Forwarded and Dropped flows will be shown. Is this ok @niklasbeinghaus?

@niklasbeinghaus please squash commits to single one and add Signed-off-by: Niklas Beinghaus <place@email.here> to that updated commit. And mark PR as ready for review, I will approve it. Thank you for your PR 👍

@niklasbeinghaus niklasbeinghaus marked this pull request as ready for review June 12, 2023 07:48
@niklasbeinghaus niklasbeinghaus requested a review from a team as a code owner June 12, 2023 07:48
@niklasbeinghaus niklasbeinghaus requested review from geakstr and removed request for a team June 12, 2023 07:48
@niklasbeinghaus niklasbeinghaus changed the title Draft: Feature: Make audit verdicts visible in hubble-ui Feature: Make audit verdicts visible in hubble-ui Jun 12, 2023
@niklasbeinghaus
Copy link
Contributor Author

@geakstr any news?

@yandzee yandzee self-requested a review July 6, 2023 11:36
@yandzee
Copy link
Collaborator

yandzee commented Jul 6, 2023

Hello @niklasbeinghaus,
@geakstr is currently on PTO, but I guess everything is done and we can merge your PR. Thank you for your work!

@yandzee
Copy link
Collaborator

yandzee commented Jul 6, 2023

Hmm, something is wrong with go linter, lets wait for next monday when @geakstr will be online

This is a WIP reagrding cilium#459

Add some color

Linting

setup correct hubble filter for audit verdict

fixed styles for audit verdict

fixed jest tests

fixed protoc plugins download

Signed-off-by: Niklas Beinghaus <niklas.beinghaus@sz.de>
Signed-off-by: Dmitry Kharitonov <dmitry@isovalent.com>
@geakstr geakstr merged commit 0a6ed74 into cilium:master Jul 10, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants