Compilers image tests #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errordeveloper
commented
Jun 22, 2020
errordeveloper
force-pushed
the
compilers-image-tests
branch
from
ec2162e
to
96c85b3
Compare
tklauser
approved these changes
Jun 23, 2020
Fix a false-positive condition Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
This will enable including tests inside the image, so that any downstream images can actually re-run the test. Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
errordeveloper
force-pushed
the
compilers-image-tests
branch
from
96c85b3
to
618bfa3
Compare
nebril
reviewed
Jun 23, 2020
| # Copyright 2017-2020 Authors of Cilium | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| set -o xtrace |
There was a problem hiding this comment.
That's being used in all of these scripts right now, these scripts themselves are temporary until #10.
| # Copyright 2017-2020 Authors of Cilium | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| set -o xtrace |
| @@ -105,7 +105,9 @@ run_buildx() { | |||
| build_args+=("${root_dir}") | |||
| fi | |||
| if [ "${do_test}" = "true" ] ; then | |||
| docker buildx build --target=test "${build_args[@]}" | |||
| if ! docker buildx build --target=test "${build_args[@]}" ; then | |||
There was a problem hiding this comment.
Not a change request, but I wonder, does isn't running with errexit set enough to exit on docker buildx failure?
There was a problem hiding this comment.
I also thought that, I was suspecting that it could be due to this function being called inside an if-clause (if ! run_buildx ; then). I'd rather not worry about it too much right now, another reason for #10 to happen sooner!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another follow-up from #43 (ref #5).