Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Added dedicated flag for persistent enforcement #2977

Conversation

PhilipSchmid
Copy link
Collaborator

@PhilipSchmid PhilipSchmid commented Oct 4, 2024

I added tetragon.enableKeepSensorsOnExit to enable persistent enforcement of the sensors even when the Tetragon process is gone/exited. Let's make this flag (--keep-sensors-on-exit) a proper Helm value instead of having users specify it via extraArgs. We should also set --release-pinned-bpf=false in case --keep-sensors-on-exit gets enabled. See 64d620e.

https://tetragon.io/docs/concepts/enforcement/persistent-enforcement/

helm: Added dedicated persistent enforcement flag

@PhilipSchmid PhilipSchmid requested a review from a team as a code owner October 4, 2024 09:35
@PhilipSchmid PhilipSchmid requested a review from tixxdz October 4, 2024 09:35
Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit a22ae99
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/66ffca9459ec270008e211b9
😎 Deploy Preview https://deploy-preview-2977--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PhilipSchmid PhilipSchmid added release-note/misc This PR makes changes that have no direct user impact. area/helm Related to the Helm chart labels Oct 4, 2024
Added `tetragon.enableKeepSensorsOnExit` to enable persistent
enforcement of the sensors although the Tetragon process is
gone/exited.

Signed-off-by: Philip Schmid <phisch@cisco.com>
@PhilipSchmid PhilipSchmid force-pushed the pr/philip/helm_flag_for_keep-sensors-on-exit branch from 7c3dd5b to a22ae99 Compare October 4, 2024 10:59
@PhilipSchmid PhilipSchmid requested review from olsajiri and removed request for tixxdz October 4, 2024 11:04
Copy link
Contributor

@olsajiri olsajiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@jrfastab jrfastab merged commit 53cf82b into cilium:main Oct 4, 2024
47 checks passed
@PhilipSchmid PhilipSchmid deleted the pr/philip/helm_flag_for_keep-sensors-on-exit branch October 4, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Related to the Helm chart release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants