Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci:github: retry Test Tetragon on failure #3001

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

tixxdz
Copy link
Member

@tixxdz tixxdz commented Oct 14, 2024

closes: #2966

Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
@tixxdz tixxdz added the release-note/minor This PR introduces a minor user-visible change label Oct 14, 2024
@tixxdz tixxdz requested review from willfindlay and a team as code owners October 14, 2024 21:49
Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit a50cd25
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/670d91d8169ed800086ae274
😎 Deploy Preview https://deploy-preview-3001--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tixxdz tixxdz requested a review from mtardy October 21, 2024 16:33
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure I imagine we can merge this but it doesn't feel very satisfying as it's not fixing the underlying issue just automating the retries.

Since in this case the commands are simple enough, maybe we should understand which commands returned != 0 and why?

@tixxdz
Copy link
Member Author

tixxdz commented Oct 21, 2024

sure I imagine we can merge this but it doesn't feel very satisfying as it's not fixing the underlying issue just automating the retries.

Since in this case the commands are simple enough, maybe we should understand which commands returned != 0 and why?

It depends since we parse logs and json events, ion tetragon startup logic, how long it takes..., or when loading policies dynamically how long it takes to add kprobes and have them on the output, so we can try to be smart, but I don't think it really worth it, or it matters since we just retry to see if events showed up or logs were successful or not.

@tixxdz tixxdz merged commit e3de28e into main Oct 21, 2024
44 checks passed
@tixxdz tixxdz deleted the pr/tixxdz/2024-10-retry-package-e2e-tetragon-tests branch October 21, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

standalone-tarball-tests is flaky
2 participants