Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --expose-kernel-addresses and --pprof-addr flags #3042

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Remove --expose-kernel-addresses and --pprof-addr flags #3042

merged 1 commit into from
Oct 24, 2024

Conversation

michi-covalent
Copy link
Contributor

@michi-covalent
Remove --expose-kernel-addresses and --pprof-addr flags
00721b2 
- The --expose-kernel-addresses flag got deprecated in v1.1 [^1].
- The --pprof-addr flag got deprecated in v1.2 [^2].

[^1]: 0d53ecc
[^2]: fe78328

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent added the release-note/minor This PR introduces a minor user-visible change label Oct 24, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 24, 2024

✅ Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 00721b2
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/671a846df39064000832b784
😎 Deploy Preview https://deploy-preview-3042--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@michi-covalent michi-covalent marked this pull request as ready for review October 24, 2024 17:36
@michi-covalent michi-covalent requested review from mtardy and a team as code owners October 24, 2024 17:36
mtardy
mtardy approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Michi for doing the cleanup work there.

@mtardy mtardy added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 24, 2024
@michi-covalent michi-covalent merged commit b9e309c into main Oct 24, 2024
49 checks passed
@michi-covalent michi-covalent deleted the pr/michi/flag-gone branch October 24, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtardy mtardy mtardy approved these changes

Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michi-covalent @mtardy