tetragon: update bpf makefile #3159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olsajiri
added
the
release-note/minor
olsajiri
force-pushed
the
pr/olsajiri/variants
branch
8 times, most recently
from
4051f63 to
b9e03b6
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Let's keep them together. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
There's no reason for the .ll step, we can compile directly to the object file. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
It's taken care of by including $(DEPS) files. All objects are by default handled by 'objs/%.o' target, plus we need to have specific rule when the object needs extra flags. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
It's more readable. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
olsajiri
force-pushed
the
pr/olsajiri/variants
branch
4 times, most recently
from
a5c31ae to
4b8a7e4
Compare
We can generate variant compilation in DEFINE_VARIANT macro. Specific CFLAGS are defined via CFLAGS_<VARIANT> variable. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
We can have just single rule for object and dependency files and provide specific CFLAGS based on object name, like: CFLAGS_bpf_enforcer.o = -D__BPF_OVERRIDE_RETURN This way it's more readable what flags are used for object. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
olsajiri
force-pushed
the
pr/olsajiri/variants
branch
from
4b8a7e4 to
90c0937
Compare
We need special rules only for multi k/u probes, the rest can be caught by generic rule. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
To put some order to objects. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
We already have them, let's use them. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Trying to explain the bpf obejcts build in nutshell. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
olsajiri
force-pushed
the
pr/olsajiri/variants
branch
from
90c0937 to
3ac9b07
Compare
kkourt
reviewed
Nov 28, 2024
olsajiri
force-pushed
the
pr/olsajiri/variants
branch
from
d604053 to
655d608
Compare
Allowing to build llvm IR objects with: $ make -C bpf objs/bpf_generic_kprobe_v61.ll Signed-off-by: Jiri Olsa <jolsa@kernel.org>
olsajiri
force-pushed
the
pr/olsajiri/variants
branch
from
655d608 to
6c3b77c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bpf makefile changes, hopefully making it more readable